Skip to content

Conversation

@0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Jul 5, 2023

example PR of migrating a standalone NFT model.

  1. made a copy of the spark spell to foundation_ethereum_base_trades_legacy.sql
  2. adapted all refs to use the _legacy spark model
  3. modified the main spell to by DuneSQL compatible

checks:

  • dbt tests are successful
  • migration data validation is successful

@0xRobin 0xRobin force-pushed the migrate-foundation branch 3 times, most recently from 5d0ccd6 to 7327ddc Compare July 5, 2023 16:49
@0xRobin 0xRobin force-pushed the migrate-foundation branch from 7327ddc to 8badbd3 Compare July 5, 2023 16:50
@0xRobin 0xRobin added dune team created by dune team DuneSQL migration labels Jul 6, 2023
@0xRobin
Copy link
Collaborator Author

0xRobin commented Jul 6, 2023

currently blocked until we merge this:
#3676

@0xRobin 0xRobin force-pushed the migrate-foundation branch from 21b068f to 18af249 Compare July 6, 2023 11:23
@0xRobin 0xRobin force-pushed the migrate-foundation branch from 18af249 to 7fc42f4 Compare July 6, 2023 11:28
Co-authored-by: Jonas Irgens Kylling <[email protected]>
@0xRobin 0xRobin mentioned this pull request Jul 6, 2023
@jkylling jkylling marked this pull request as ready for review July 6, 2023 17:07
@jkylling
Copy link
Contributor

jkylling commented Jul 6, 2023

I've ran the data quality script and verified that the data looks correct.

@jeff-dude
Copy link
Member

note: merging with spark prod job in "dummy mode", i.e. no steps to run. trino will have the normal steps.

@jeff-dude jeff-dude merged commit 0d495a1 into duneanalytics:main Jul 6, 2023
@0xRobin 0xRobin mentioned this pull request Jul 7, 2023
2 tasks
olgafetisova pushed a commit to olgafetisova/spellbook that referenced this pull request Nov 14, 2023
* migrate foundation_ethereum_base_trades

* migrate foundation seed test

* fix check_seed_macro

* tag test with sources as dunesql

* exclusion tag in git CI seed step

* try different approach for sources

* typo

* Update macros/dune/source.sql

Co-authored-by: Jonas Irgens Kylling <[email protected]>

---------

Co-authored-by: Jonas Irgens Kylling <[email protected]>
Co-authored-by: jeff-dude <[email protected]>
@0xRobin 0xRobin deleted the migrate-foundation branch May 20, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dune team created by dune team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants