-
Notifications
You must be signed in to change notification settings - Fork 1.4k
migrate foundation_ethereum_base_trades #3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d0ccd6 to
7327ddc
Compare
7327ddc to
8badbd3
Compare
|
currently blocked until we merge this: |
21b068f to
18af249
Compare
18af249 to
7fc42f4
Compare
jkylling
approved these changes
Jul 6, 2023
Co-authored-by: Jonas Irgens Kylling <[email protected]>
Merged
|
I've ran the data quality script and verified that the data looks correct. |
|
note: merging with spark prod job in "dummy mode", i.e. no steps to run. trino will have the normal steps. |
jeff-dude
approved these changes
Jul 6, 2023
olgafetisova
pushed a commit
to olgafetisova/spellbook
that referenced
this pull request
Nov 14, 2023
* migrate foundation_ethereum_base_trades * migrate foundation seed test * fix check_seed_macro * tag test with sources as dunesql * exclusion tag in git CI seed step * try different approach for sources * typo * Update macros/dune/source.sql Co-authored-by: Jonas Irgens Kylling <[email protected]> --------- Co-authored-by: Jonas Irgens Kylling <[email protected]> Co-authored-by: jeff-dude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example PR of migrating a standalone NFT model.
foundation_ethereum_base_trades_legacy.sql_legacyspark modelchecks: